Re: [PR] fix(dashboard): release shared filter fallback on chart clicks [superset]

[codeant-ai-for-open-source[bot] (via GitHub) via notifications]

codeant-ai-for-open-source[bot] commented on code in PR #45954:
URL: https://github.com/apache/superset/pull/45954#discussion_r4444415403


##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -516,6 +517,12 @@ function ChartRendererComponent({
   dataMaskSourceRef.current = latestQueryFormData ?? formData;
   const setDataMaskCallback = useCallback(
     (dataMask: DataMask) => {
+      if (
+        dataMask.filterState !== undefined ||
+        dataMask.extraFormData !== undefined
+      ) {
+        releaseFilterKeyPublish();

Review Comment:
   **Suggestion:** If a chart mask changes while Try again is fetching, the 
request still hydrates afterward and overwrites the viewer’s selection; a 
failed request can also restore the warning.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Race condition`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=8b3abefb9c2647c98c496ec4531eb9cc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=8b3abefb9c2647c98c496ec4531eb9cc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset-frontend/src/components/Chart/ChartRenderer.tsx
   **Line:** 524:524
   **Comment:**
        *Race Condition: If a chart mask changes while Try again is fetching, 
the request still hydrates afterward and overwrites the viewer’s selection; a 
failed request can also restore the warning.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45954&comment_hash=7c1add7cb0059531d877a41a1711956c018a458dd8ed5c8823a66f237eb93e87&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45954&comment_hash=7c1add7cb0059531d877a41a1711956c018a458dd8ed5c8823a66f237eb93e87&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org