fitzee opened a new pull request, #45954: URL: https://github.com/apache/superset/pull/45954
## TL;DR Clicking a chart to cross-filter after a shared-link fallback should dismiss the warning and its Try again action. Release the saved-filter hold from the chart renderer's plugin hook, so retry cannot subsequently replace that viewer selection. Pagination-only updates keep the fallback active. ### SUMMARY Follow-up to https://github.com/apache/superset/pull/45928. The query-building callback and context-menu paths already release the hold, but the hook passed to rendered chart plugins did not. Check the incoming mask for `filterState` or `extraFormData` before dispatching it. Keep the original key protected from overwrite and preserve the renderer's existing semantic-selection handling. Document shared-view fallback behavior and scope the sharing-warning claim to the dashboard Share menu. Tab/heading anchor copies and the embedded permalink API do not display that warning. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No new visual design. After a fallback, a chart cross-filter dismisses the existing warning and Try again button; previously both remained. No browser screenshots were captured. ### TESTING INSTRUCTIONS Changed-file pre-commit checks, including frontend type checking, pass. 60 tests pass on Node 24: ```sh npm run test -- --runInBand \ src/components/Chart/ChartRenderer.test.tsx \ src/dashboard/containers/DashboardPage.test.tsx \ src/dashboard/util/sharedFilterStateHold.test.ts ``` The new renderer regression invokes the plugin hook through the mocked chart UI. Both filterState and extraFormData cases fail on the parent commit and pass with this change; ownState-only pagination passes in both. It also asserts release notification before dispatch, unchanged mask forwarding, and continued original-key protection. Existing DashboardPage tests cover removing the warning after release. Manual: stall a shared dashboard link's filter-state request until fallback, then click a chart to cross-filter. The warning and Try again should disappear. Repeat with table pagination: the warning should remain. Live browser validation has not been performed. ### ADDITIONAL INFORMATION - No feature flags, migrations, API changes or new dependencies. - Follow-ups outside this change: URL-filter chip/customization removal, warning coverage for other sharing paths, and preserving `f=` filters on Try again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
