codeant-ai-for-open-source[bot] commented on code in PR #45952:
URL: https://github.com/apache/superset/pull/45952#discussion_r4442812026
##########
superset/commands/streaming_export/base.py:
##########
@@ -338,6 +321,13 @@ def _execute_query_and_stream(
with merged_database.get_sqla_engine(
catalog=catalog, schema=schema
) as engine:
+ # Building the engine may have refreshed the user's OAuth2
+ # token, which is only staged on the session. Commit it, as the
+ # buffered export's query logging does, instead of losing it
+ # when the session closes (a single-use refresh token would be
+ # spent), and so no metadata transaction is held open while the
+ # rows stream.
+ session.commit() # pylint: disable=consider-using-transaction
Review Comment:
**Suggestion:** For an expired token, the refresh lock is released before
this commit. Another export can redeem the still-committed single-use refresh
token, causing one refresh to fail.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=32e9b9c5c2814baf85530329f0c7429e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=32e9b9c5c2814baf85530329f0c7429e&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/streaming_export/base.py
**Line:** 330:330
**Comment:**
*Race Condition: For an expired token, the refresh lock is released
before this commit. Another export can redeem the still-committed single-use
refresh token, causing one refresh to fail.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45952&comment_hash=69c1d00a55fb9b9ac2a7fd8e780d3564041a91614e853aa6f04558b013eb165c&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45952&comment_hash=69c1d00a55fb9b9ac2a7fd8e780d3564041a91614e853aa6f04558b013eb165c&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
