geido commented on PR #45952: URL: https://github.com/apache/superset/pull/45952#issuecomment-6611254685
Pushed the two fixes from the last review: the export reloads the database instead of merging it, and it no longer pushes the request again when the body is read before the request ends. I also ran it end to end on master, against a local Snowflake stand-in that only accepts OAuth logins: 1, 10 and gevent workers, CSV compression, a latin-1 export, Redis locks, the deployment-wide OAuth2 client, CSV reports and embedded guests. Every export also checks that the metadata rows don't change and that the next requests on the worker don't see the exporting user. All of these pass on this branch. Live run of the main cases, before the fix, on the previous revision and on this branch: https://github.com/user-attachments/assets/5408babf-c127-4254-99f6-2ba06bc5a9b3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
