nextjohnp7 commented on PR #45930: URL: https://github.com/apache/superset/pull/45930#issuecomment-6583199488
Hi @hainenber, thanks for the review and apologies for the mess — this is my first contribution to Superset. You were completely right: the CHANGE_ME_* constants are intentional placeholders, the unrelated changes were from a botched rebase, and PR_DETAILS.md was unnecessary. I've closed this PR and split the valuable work (the SDK test suite and JSDoc) into a clean, focused PR here: #<45957>. Thanks for the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
