hainenber commented on code in PR #45930:
URL: https://github.com/apache/superset/pull/45930#discussion_r4443738472
##########
Dockerfile:
##########
@@ -360,27 +353,26 @@ RUN --mount=type=cache,target=${SUPERSET_HOME}/.cache/uv \
# FROM lean, which is already past that arg. Chromium ships for both
# linux/amd64 and linux/arm64, so this works on multi-platform builds.
# See the INCLUDE_CHROMIUM step in python-common for --use-openssl-ca.
+ARG INCLUDE_CHROMIUM="false"
RUN --mount=type=cache,target=${SUPERSET_HOME}/.cache/uv \
- uv pip install playwright \
- && playwright install-deps \
- && NODE_OPTIONS=--use-openssl-ca
SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt \
- playwright install chromium
+ if [ "${INCLUDE_CHROMIUM}" = "true" ]; then \
+ uv pip install playwright \
+ && playwright install-deps \
+ && NODE_OPTIONS=--use-openssl-ca
SSL_CERT_FILE=/etc/ssl/certs/ca-certificates.crt \
+ playwright install chromium; \
+ else \
+ echo "Skipping Playwright/Chromium installation"; \
+ fi
USER superset
######################################################################
# Dev image...
######################################################################
FROM python-common AS dev
+RUN /app/docker/apt-install.sh git pkg-config default-libmysqlclient-dev
Review Comment:
Why is this change here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
