rebenitez1802 commented on code in PR #45859:
URL: https://github.com/apache/superset/pull/45859#discussion_r4442990348
##########
superset/sql/execution/celery_task.py:
##########
@@ -661,6 +661,14 @@ def _execute_sql_statements(
level=ErrorLevel.ERROR,
)
) from ex
+ except Exception:
Review Comment:
Narrowed in 1b183c6: the executor now handles quietly only an engine's
explicit stop signal, a new `QueryStoppedException` that Impala's fetch raises
once it has cancelled the operation. Any other failure goes through the normal
error path with its traceback and `error_sqllab_unhandled`, even when a stop
raced it, and the query still ends stopped because `_handle_query_error` checks
for the stop first. The test now covers both cases.
##########
docs/admin_docs/configuration/configuring-superset.mdx:
##########
@@ -835,6 +835,16 @@ pending when result fetching begins, the additional
polling wait is bounded by
a timeout. Configure the driver's network timeout separately to bound
individual
RPC calls.
+Impala reports a streaming `SELECT` as finished as soon as its rows can be
fetched,
+so most of such a query runs while SQL Lab reads its results. While it
fetches, the
+worker checks for a stop between result RPCs, at most once per
+`DB_POLL_INTERVAL_SECONDS`, and cancels the query on its own connection. Each
result
+RPC returns within Impala's `FETCH_ROWS_TIMEOUT_MS` query option (10 seconds by
+default, available from Impala 3.4) even when no rows are ready, so a stop
takes
+effect within about `FETCH_ROWS_TIMEOUT_MS` plus `DB_POLL_INTERVAL_SECONDS`;
+lowering either makes stops take effect sooner. Impala checks for cancellation
between row batches, so a batch whose
Review Comment:
Applied your suggestion in 1b183c6, and added the same note about
`FETCH_ROWS_TIMEOUT_MS=0` to UPDATING.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
