rebenitez1802 commented on PR #45859: URL: https://github.com/apache/superset/pull/45859#issuecomment-6661969802
Thanks @aminghadersohi, all four notes are addressed: 1. **End-to-end test.** a6e8be8 adds `test_impala_fetch_stop_reaches_the_executor`. It carries a real `ImpalaFetchStoppedError` from the result fetch through `_execute_sql_statements`, against a real session. Each of your two mutations, subclassing `Exception` or dropping `preserve_pending=True`, fails it. 2. **Soft time limit.** `test_timeout_during_a_stop_check_is_not_swallowed` also covers `SoftTimeLimitExceeded` (a6e8be8). Narrowing the handler to `TIME_LIMIT_EXCEPTIONS[1:]` fails it. 3. **Post-poll rollback.** 9eb3225 moves the rollback into `_stop_requested`, so a failed check rolls the session back before it propagates, from either caller. `test_failed_post_poll_stop_check_rolls_back_the_session` covers an operation that is finished at its first poll. 4. **Truncation probe.** 6bd9d8a makes `check_truncated` re-raise `QueryStoppedException` alongside the time limits, so the stop reaches the executor without the warning. `test_execute_truncation_probe_propagates_an_engine_stop` covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
