aminghadersohi commented on code in PR #45912:
URL: https://github.com/apache/superset/pull/45912#discussion_r4447858661
##########
superset-core/src/superset_core/semantic_layers/testing.py:
##########
@@ -272,6 +290,56 @@ def test_imports_and_static_schema(
assert completed.returncode == 0, completed.stdout + completed.stderr
+def _assert_null_placement_witness(
+ query: SemanticQuery, view: SemanticView, expected: pa.Table
+) -> None:
+ """Require NULL values of the first order key where its placement puts
them.
+
+ The host's default chronological order asks for NULL values last; a
+ provider must honor a placement on any order key, before offset and limit.
+ The page must keep different rows from the ones the opposite placement
would.
+ """
+ assert query.order, "null_placement fixture requires an order"
+ first: tuple[object, ...] = query.order[0]
Review Comment:
`get_table` requires "including any term's NULL placement" (`view.py:175`).
Dropping placement only after the first key still passes all 65 conformance
tests; add a tied-prefix multi-key witness whose page changes when secondary
placement is dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
