codeant-ai-for-open-source[bot] commented on code in PR #45912:
URL: https://github.com/apache/superset/pull/45912#discussion_r4444019735
##########
superset-core/src/superset_core/semantic_layers/testing.py:
##########
@@ -272,6 +290,56 @@ def test_imports_and_static_schema(
assert completed.returncode == 0, completed.stdout + completed.stderr
+def _assert_null_placement_witness(
+ query: SemanticQuery, view: SemanticView, expected: pa.Table
+) -> None:
+ """Require NULL values of the first order key where its placement puts
them.
+
+ The host's default chronological order asks for NULL values last; a
+ provider must honor a placement on any order key, before offset and limit.
+ The page must keep different rows from the ones the opposite placement
would.
+ """
+ assert query.order, "null_placement fixture requires an order"
+ first: tuple[object, ...] = query.order[0]
Review Comment:
**Suggestion:** The required case only inspects `query.order[0]`, so a
provider that ignores NULL placement on later `OrderTerm`s can pass despite the
per-term SDK contract.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Incomplete
implementation`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d1e475507759402d9614d8be20b34661&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d1e475507759402d9614d8be20b34661&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-core/src/superset_core/semantic_layers/testing.py
**Line:** 303:303
**Comment:**
*Incomplete Implementation: The required case only inspects
`query.order[0]`, so a provider that ignores NULL placement on later
`OrderTerm`s can pass despite the per-term SDK contract.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45912&comment_hash=cb577b55b94cba9e4a414bb33d8546ddd40144dfe238f620f15568fce08e3a22&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45912&comment_hash=cb577b55b94cba9e4a414bb33d8546ddd40144dfe238f620f15568fce08e3a22&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
