mistercrunch commented on a change in pull request #8867: [WIP] Customize 
schema name for the CTA queries
URL: 
https://github.com/apache/incubator-superset/pull/8867#discussion_r360617020
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -499,6 +499,13 @@ class CeleryConfig(object):  # pylint: 
disable=too-few-public-methods
 # timeout.
 SQLLAB_QUERY_COST_ESTIMATE_TIMEOUT = 10  # seconds
 
+# Flag that controls if limit should be inforced on the create table as 
queries.
+SQLLAB_CTA_NO_LIMIT = False
+
+# Function accepts username, schema name and sql that will be run e.g.:
 
 Review comment:
   It's not super clear here what this does or why you'd want to use this 
config element. I had to read a bit of code to understand it.
   
   ```
   This allows you to define custom logic around the "CREATE TABLE AS" or CTAS 
feautre in SQL Lab that defines where the target schema should be for a given 
user.
   ```
   Then add a proper example with type annotation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to