mistercrunch commented on a change in pull request #8867: [WIP] Customize
schema name for the CTA queries
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r360617619
##########
File path: superset/views/core.py
##########
@@ -2644,8 +2662,9 @@ def sql_json_exec(
)
# set LIMIT after template processing
- limits = [mydb.db_engine_spec.get_limit_from_sql(rendered_query),
limit]
- query.limit = min(lim for lim in limits if lim is not None)
+ if not config.get("SQLLAB_CTA_NO_LIMIT", False):
Review comment:
We can assume that the key exists no need for default to False here, and if
would be False anyways if the key doesn't exist
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
