eugeneo17 commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-6582701002
Thanks for the detailed review. Based on the feedback this PR has been reworked substantially. **Synthesis now reuses the canonical builder.** `query_context_builder` no longer carries its own form-data→query mapping. It delegates to `superset.common.form_data_query_context.build_query_context_from_form_data` (the same builder the dashboard Excel export and the MCP chart service use), so the synthesized context matches what the server already produces elsewhere. **The embedded V8/`py_mini_racer` buildQuery path has been removed from this PR** and will be proposed separately as a SIP, since it adds a native dependency and a frontend bundle to the images. This drops the PR from ~83 files to ~13 and removes the generator, the frontend `backend-querycontext` bundle/fixtures/goldens, the packaging extra, and the Dockerfile/CI wiring, which makes most of the earlier threads obsolete (they point at deleted files). **Follow-up `d3301a2131` addresses the two correctness points raised on the canonical-builder revision:** synthesis is now allowlisted to the viz types the builder maps explicitly (unmapped viz such as `sankey_v2`/`graph_chart` stay NULL instead of saving a wrong context), charts carrying dashboard-context filters (`extra_filters`/`extra_form_data`) are left NULL, and a builder-injected `time_range="No filter"` is dropped when it would clobber a bound `TEMPORAL_RANGE` adhoc filter. New pure unit tests cover these gates. I'll resolve the V8-related threads that now reference removed code; please re-open anything I close too eagerly. Ready for another pass when CI is green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
