eugeneo17 commented on PR #43303: URL: https://github.com/apache/superset/pull/43303#issuecomment-6663864141
@sadpandajoe @rusackas thanks for the thorough pass. All open threads from the 2026-11-03 review are addressed in 5bb17ea213: - **Dashboard-context guard** now leaves a chart NULL on any non-empty `extra_filters`/`extra_form_data` and their `_b` variants (covers the `time_grain_sqla`-only and `mixed_timeseries` `_b`-only cases). - **TEMPORAL_RANGE preservation** is now per query, not per chart (dropped the chart-wide `had_explicit_time_range` gate), so a `mixed_timeseries` query B keeps its bound `_b` range when only A has a top-level range. New regression test included. - **Duplicate `logger`** in `importers/v1/utils.py` removed. - **CLI coverage** added: `--dry-run` writes nothing, and per-chart error isolation (malformed `params`, `--batch-size 1`, asserts `errors 1` and that later batches still fill). Replied inline on each thread. Ready for another review pass once CI runs (it re-gates to `action_required` on each push until a committer approves the workflow). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
