proBieri commented on code in PR #45965:
URL: https://github.com/apache/superset/pull/45965#discussion_r4459851681
##########
superset/translations/de/LC_MESSAGES/messages.po:
##########
@@ -17621,8 +17600,33 @@ msgstr ""
"Zum Importieren der unten aufgeführten Datenbanken werden die "
"entsprechenden Passwörter benötigt."
-msgid "The pattern of timestamp format. For strings use "
-msgstr "Das Muster des Zeitstempelformats. Verwenden Sie für Zeichenfolgen
eine "
+#. i18n: translate the whole sentence, including the link
+#. text; keep the [text](%(…)s) link syntax, the backticks
+#. and both placeholders unchanged
+#, python-format
+msgid ""
+"The pattern of timestamp format. For strings use [Python datetime string "
+"pattern](%(python_url)s) expression which needs to adhere to the [ISO "
+"8601](%(iso_url)s) standard to ensure that the lexicographical ordering "
+"coincides with the chronological ordering. If the timestamp format does "
+"not adhere to the ISO 8601 standard you will need to define an expression"
+" and type for transforming the string into a date or timestamp. Note "
+"currently time zones are not supported. If time is stored in epoch "
+"format, put `epoch_s`, `epoch_ms` or `epoch_us`. If no pattern is "
+"specified we fall back to using the optional defaults on a per "
+"database/column name level via the extra parameter."
+msgstr ""
+"Das Muster des Zeitstempelformats. Verwenden Sie für Zeichenfolgen eine "
+"[Python Datetime-Zeichenfolge](%(python_url)s) die dem [ISO "
+"8601](%(iso_url)s) Standard, damit die lexikographische Reihenfolge mit "
Review Comment:
Thanks for joining the fragments! The German sentence was already broken on
master: the old fragment `" die dem "` left the relative clause without a verb.
Suggested fix:
```suggestion
"Das Muster des Zeitstempelformats. Verwenden Sie für Zeichenfolgen ein "
"[Python-Datetime-Zeichenfolgenmuster](%(python_url)s), das dem Standard "
"[ISO 8601](%(iso_url)s) entsprechen muss, damit die lexikographische "
"Reihenfolge mit "
```
- adds the missing verb ("entsprechen muss") and the comma before the
relative clause
- restores "Muster" (pattern) in the link text and hyphenates the compound
("Python-Datetime-Zeichenfolgenmuster")
- uses "dem Standard [ISO 8601](…)" so no hyphen has to follow the link
The rest of the msgstr is unchanged. Placeholders and backticks stay as they
are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
