antalotec commented on issue #45986: URL: https://github.com/apache/superset/issues/45986#issuecomment-6628350026
Thanks — all four points match what we found. On the first: we can confirm `check_translation_regression.py` would not catch this. It compares translated and fuzzy counts and keys on a confirmed translation turning fuzzy, so a `msgstr` edited in place — which is what happened here — moves neither number. On the second: agreed, and it is worth being explicit that these 64 entries are invisible to every check currently in place. `msgfmt --check` passes on both catalogs for all of them, because the placeholders are all present and correctly counted; only their position changed. `pt` reports a single fatal error today, and it belongs to an unrelated entry. On the third: agreed, a locale-scoped review warning is the right shape. The heuristic only holds for languages that delimit words with spaces — on `zh`, `ja` and `th` it reports false positives — so it could not be a hard requirement across the board. On the fourth, thank you for raising it: we checked, and it is so. `pybabel compile --use-fuzzy` in the `Dockerfile` and `scripts/po2json-cli.js` on the frontend both keep fuzzy entries, so marking these would hide them from `msgfmt` while still shipping them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
