DamianPendrak commented on PR #45985:
URL: https://github.com/apache/superset/pull/45985#issuecomment-6642028076
That's great, thanks! Just two small things left:
1. On required filters the `*` now comes after the warning icon ("Name ⚠
*"). Could the `*` stay right after the name, with the icon after it?
2. In the `.po` files the new message was inserted below the `#,
python-format` line of the next message. So the flag now sits on the new
string, which has no %s, and “This filter might be incompatible with current
%s” has lost it. Could you move the flag back down to that string? Running
`scripts/translations/babel_update.sh` also fixes it, but it pulls in a few
unrelated new strings too.
<img width="800" height="600" alt="image"
src="https://github.com/user-attachments/assets/ec34a28f-5e4a-40cd-9fbb-11649e513080";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
