PrakharAgarwal17 opened a new pull request, #45985:
URL: https://github.com/apache/superset/pull/45985

   ### SUMMARY
   
   Fixes: #45981
   
   A native dashboard filter whose scope has no charts selected (no boxes 
checked)
   is shown in the filter bar like any other filter, but it does nothing. 
Nothing
   tells the user that, so they can pick values and wonder why no chart changes.
   
   This PR makes such filters visibly different without changing how they work:
   
   - Added a helper that detects filters with an empty scope.
   - For those filters, the filter name is shown muted/grey and a warning icon
     is added next to it.
   - Hovering shows a tooltip: "This filter isn't applied to any charts yet".
   - The filter is **not** disabled: existing selection, default value and
     required behavior stay exactly the same.
   - Filters that are scoped to at least one chart look the same as before.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before:** 
   
   <img width="722" height="497" alt="image" 
src="https://github.com/user-attachments/assets/616f6ed0-13bd-465c-8038-b6443ef62c30";
 />
   
   
   **After:** 
   
   <img width="597" height="368" alt="image" 
src="https://github.com/user-attachments/assets/3c144952-03e3-4f8e-975c-1060e11ac669";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

  • [PR] fix(na... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... netlify[bot] (via GitHub) via notifications
    • Re: [P... codecov[bot] (via GitHub) via notifications
    • Re: [P... DamianPendrak (via GitHub) via notifications
    • Re: [P... sfirke (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... PrakharAgarwal17 (via GitHub) via notifications
    • Re: [P... codeant-ai-for-open-source[bot] (via GitHub) via notifications
    • Re: [P... DamianPendrak (via GitHub) via notifications

Reply via email to