mikebridge opened a new pull request, #46020: URL: https://github.com/apache/superset/pull/46020
### SUMMARY TL;DR: Interactive Table omits an unused default Day grain from semantic aggregate requests when current metadata proves there is no selected time column. Background: Table already applies this conservative normalization. The shared time-grain control can retain its Day default while hidden, and Interactive Table was still sending it, causing a missing-time-column validation error. This shares Table's existing rule with Interactive Table and supplies current dashboard temporal-column metadata to both plugins. Normalization runs on each final query, including pagination and totals queries. Saved form data is unchanged. Temporal selections, unknown metadata, SQL expressions and explicit time axes retain normal validation; SQL datasets and raw queries are unaffected. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Not applicable: request construction only. A non-temporal semantic Interactive Table request previously included `time_grain_sqla: P1D`; it omits that dormant grain after this change. ### TESTING INSTRUCTIONS 1. With semantic layers enabled, create an Interactive Table using a semantic view, a non-temporal dimension and a metric. Leave the Day control default with no time column selected. 2. Verify Explore preview, dashboard load, pagination and CSV export succeed without sending a time grain. Enable totals and check the derived requests too. 3. Select a temporal column and verify the requested grain is retained. Verify ordinary SQL datasets and plain Table behavior are unchanged. Automated: 235 passed, 1 existing skip across Interactive Table buildQuery, dashboard Chart and plain Table buildQuery suites. New cases fail on master. Changed-file hooks, including frontend type checking, pass. Live-provider/browser validation has not been run. The reported plain Table symptom does not reproduce on current master with current metadata; this patch addresses the confirmed Interactive Table gap. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [x] Required feature flags: `SEMANTIC_LAYERS` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
