Re: [PR] fix(table): omit dormant time grains from semantic interactive queries [superset]

codeant-ai-for-open-source[bot] (via GitHub) via notifications Wed, 04 Nov 2026 18:42:15 -0800


codeant-ai-for-open-source[bot] commented on code in PR #46020:
URL: https://github.com/apache/superset/pull/46020#discussion_r4475840439



##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx:
##########
@@ -499,7 +499,8 @@ const Chart = (props: ChartProps) => {
       ownColorScheme,
     });
     if (
-      chart?.form_data?.viz_type !== VizType.Table ||
+      (chart?.form_data?.viz_type !== VizType.Table &&
+        chart?.form_data?.viz_type !== VizType.TableAgGrid) ||

Review Comment:
   **Suggestion:** `TableAgGrid` now uses any matching-dashboard metadata 
snapshot; during a refresh, stale `is_dttm: false` values can make its builder 
omit a required time grain.
   
   **Assessment:** 🟠 `Major` · 🔁 `Occurrence: Rarely` · 🏷️ `Stale reference`
   
   [![Use CodeAnt 
Skill](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/use-codeant-skill-flat-v2.svg)](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
 [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c7ec2a810b634085bf319726afacfe63&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c7ec2a810b634085bf319726afacfe63&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** 
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.tsx
   **Line:** 502:503
   **Comment:**
        *Stale Reference: `TableAgGrid` now uses any matching-dashboard 
metadata snapshot; during a refresh, stale `is_dttm: false` values can make its 
builder omit a required time grain.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F46020&comment_hash=4006eadfcf4854fe949699432de90a11559a8007249feb00ff83e47e4aafab42&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F46020&comment_hash=4006eadfcf4854fe949699432de90a11559a8007249feb00ff83e47e4aafab42&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix(table): omit dormant time grains from semantic interactive queries [superset]

Reply via email to