[GitHub] [incubator-superset] villebro opened a new pull request #9033: Add schema to function retrieval and implement for Snowflake

Tue, 28 Jan 2020 08:12:26 -0800 

villebro opened a new pull request #9033: Add schema to function retrieval and 
implement for Snowflake
URL: https://github.com/apache/incubator-superset/pull/9033
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Some databases, like Snowflake, support defining UDFs per schema. This PR 
adds the possibility to retrieve both global functions and schema-specific 
UDFs, and implements said functionality for Snowflake. Achieving this required 
moving the function retrieval from the database api to the table api, and 
making small modifications in the frontend code.
   
   ### SCREENSHOTS
   In the first picture we are browsing a schema where the UDF `SFWHO` is 
available: 
   <img width="697" alt="Screenshot 2020-01-28 at 17 51 54" 
src="https://user-images.githubusercontent.com/33317356/73281746-1567ae80-41f9-11ea-9d0c-07a7d7135d12.png";>
   
   When browsing a schema without UDFs, only the global functions show up:
   <img width="698" alt="Screenshot 2020-01-28 at 17 51 16" 
src="https://user-images.githubusercontent.com/33317356/73281661-fc5efd80-41f8-11ea-80a7-13a342060e7c.png";>
   
   ### TEST PLAN
   Tested locally.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to