john-bodley commented on a change in pull request #9033: feat: Add schema to
function retrieval and implement for Snowflake
URL:
https://github.com/apache/incubator-superset/pull/9033#discussion_r372659361
##########
File path: superset/db_engine_specs/hive.py
##########
@@ -429,12 +429,26 @@ def execute( # type: ignore
@classmethod
@cache.memoize()
Review comment:
Somewhat unrelated to your change I noticed there a relative new caching
structure defined
[here](https://github.com/apache/incubator-superset/blob/master/superset/utils/cache.py#L27)
which provides caching at the database level. I'm not sure if there's merit in
using that in favor of the global cache, but I do wonder if we should be using
the `tables_cache` rather than the `cache` for table, i.e., SQL Lab, related
caching.
Note it's all a little confusing when a cached object expires given the
plethora of caches which now seem to exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
