willbarrett commented on a change in pull request #9054: [database] new, select
star API migration
URL:
https://github.com/apache/incubator-superset/pull/9054#discussion_r374230100
##########
File path: tests/core_tests.py
##########
@@ -830,12 +830,6 @@ def test_schemas_access_for_csv_upload_endpoint(
assert data == ["this_schema_is_allowed_too"]
self.delete_fake_db()
- def test_select_star(self):
Review comment:
Since we're keeping the `/superset/select_star` endpoint for now, let's also
keep the related test. It would be good to add another test to ensure the
additional database permission check is working properly on this endpoint too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
