dpgaspar commented on a change in pull request #9054: [database] new, select
star API migration
URL:
https://github.com/apache/incubator-superset/pull/9054#discussion_r374400871
##########
File path: superset/views/core.py
##########
@@ -1958,11 +1958,26 @@ def extra_table_metadata(self, database_id,
table_name, schema):
@expose("/select_star/<database_id>/<table_name>/<schema>")
@event_logger.log_this
def select_star(self, database_id, table_name, schema=None):
- mydb = db.session.query(models.Database).get(database_id)
+ logging.warning(
+ "This API endpoint is deprecated and will be removed in version
1.0.0"
Review comment:
I've added the following metrics:
- init_Superset.select_star
- database_not_found_Superset.select_star
- permission_denied_Superset.select_star
- success_Superset.select_star
- init_DatabaseRestApi.select_star
- database_not_found_DatabaseRestApi.select_star
- permission_denied_DatabaseRestApi.select_star
- success_DatabaseRestApi.select_star
- init_DatabaseRestApi.table
- database_not_found_DatabaseRestApi.table
- permission_denied_DatabaseRestApi.table
- success_DatabaseRestApi.table
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
