graceguo-supercat opened a new pull request #9087: [logging] Add Auto Refresh 
Dashboard user event into dashboard logging
URL: https://github.com/apache/incubator-superset/pull/9087
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   In Dashboard, we allow dashboard owner set a `refresh_frequency` and save it 
with dashboard metadata. A dashboard with refresh_frequency (> 0) will auto 
force-refresh itself periodically once it is loaded in browser. But this 
auto-refresh event is not logged correctly in current dashboard logging 
mechanism. 
   
   This PR is to add auto refresh event, and a little code refactor for the 
period rendering function.
   
   ### TEST PLAN
   Test is covered by existed integration tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @etr2460 @serenajiang 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to