etr2460 commented on a change in pull request #9087: [logging] Add Auto Refresh
Dashboard event into dashboard logging
URL:
https://github.com/apache/incubator-superset/pull/9087#discussion_r375383102
##########
File path: superset/assets/src/dashboard/components/Header.jsx
##########
@@ -188,7 +188,7 @@ class Header extends React.PureComponent {
forceRefresh() {
if (!this.props.isLoading) {
- const chartList = Object.values(this.props.charts);
+ const chartList = Object.keys(this.props.charts);
Review comment:
what's the value in only passing around the chart keys instead of the chart
object? It looks like we still need to get the whole object from state when we
actually fetch the chart, so does this save much?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
