mistercrunch commented on a change in pull request #8867: Make schema name for
the CTA queries and limit configurable
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r375097500
##########
File path: tests/base_tests.py
##########
@@ -222,22 +222,27 @@ def run_sql(
query_limit=None,
database_name="examples",
sql_editor_id=None,
+ select_as_cta=False,
+ tmp_table_name=None,
):
if user_name:
self.logout()
self.login(username=(user_name or "admin"))
dbid = self._get_database_by_name(database_name).id
+ json_payload = dict(
+ database_id=dbid,
+ sql=sql,
+ client_id=client_id,
+ queryLimit=query_limit,
+ sql_editor_id=sql_editor_id,
+ )
Review comment:
Personally I don't feel strongly about this. If a linter can't enforce it,
I'd say either approaches are fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
