villebro commented on a change in pull request #8867: Make schema name for the
CTA queries and limit configurable
URL:
https://github.com/apache/incubator-superset/pull/8867#discussion_r381417443
##########
File path: tests/celery_tests.py
##########
@@ -172,11 +176,12 @@ def test_run_sync_query_cta(self):
query2 = self.get_query_by_id(result["query"]["serverId"])
# Check the data in the tmp table.
- if backend != "postgresql":
- # TODO This test won't work in Postgres
- results = self.run_sql(db_id, query2.select_sql, "sdf2134")
- self.assertEqual(results["status"], "success")
- self.assertGreater(len(results["data"]), 0)
+ results = self.run_sql(db_id, query2.select_sql, "sdf2134")
+ self.assertEqual(results["status"], "success")
+ self.assertGreater(len(results["data"]), 0)
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
