etr2460 commented on a change in pull request #9088: [dashboard] Fix metadata
state
URL:
https://github.com/apache/incubator-superset/pull/9088#discussion_r375407843
##########
File path: superset/assets/src/dashboard/components/PropertiesModal.jsx
##########
@@ -49,19 +50,25 @@ const defaultProps = {
class PropertiesModal extends React.PureComponent {
constructor(props) {
super(props);
+ this.defaultMetadataValue = JSON.stringify(
Review comment:
this will throw if the metadata is invalid, is that what we want here? Maybe
we should wrap it in a try/catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
