[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #9088: [dashboard] Fix metadata state

[GitBox]

graceguo-supercat edited a comment on issue #9088: [dashboard] Fix metadata 
state
URL: 
https://github.com/apache/incubator-superset/pull/9088#issuecomment-582671214
 
 
   @suddjian Thanks for this fix. I also found a few dashboard metadata was 
missing and almost filed an issue.
   
   Here is a list of metadata:
   
https://github.com/apache/incubator-superset/blob/315a11dfe265c6a20ed014610eb7351966292c38/superset/views/dashboard/api.py#L44
   
   But there are another 2 fields not in the above list:  **`color scheme`** 
and **`label_colors`**:
   
   <img width="520" alt="Screen Shot 2020-02-05 at 3 49 58 PM" 
src="https://user-images.githubusercontent.com/27990562/73894137-5e8ab480-4830-11ea-99fa-7f3398dfa8ad.png";>
   
   
   <img width="592" alt="Screen Shot 2020-02-05 at 3 57 56 PM" 
src="https://user-images.githubusercontent.com/27990562/73894107-49ae2100-4830-11ea-909d-5747b5b7588e.png";>
   
   Not sure these 2 extra fields will be picked up in this PR.
   And if possible, could you add these 2 fields into 
`DashboardJSONMetadataSchema` (it's out of scope of this PR)? Thank you!
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org