suddjian opened a new pull request #9098: Moving frontend code to its own top-level directory URL: https://github.com/apache/incubator-superset/pull/9098 ### CATEGORY - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Implements changes outlined in [SIP-32](https://github.com/apache/incubator-superset/issues/8805). Removes the need for a symlink from `superset/static` to `superset/assets` by moving "assets" to a new top-level `/superset-frontend` directory. Webpack now outputs into the `superset/static` folder, copying any necessary assets. ### TEST PLAN <!--- What steps should be taken to verify the changes --> Running `npm run build`, `npm run dev`, and `npm run dev-server` all seem to work correctly. Building the tarball seems to work fine, but could use additional verification as I'm not sure what all the failure states there might be. Docker build seems to work fine, but could also use more verification here. CI remains to be seen, this PR will test that ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Closes #8805 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @nytai @willbarrett @mistercrunch @craig-rueda @DiggidyDave @villebro
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
