nytai commented on a change in pull request #9098: SIP-32: Moving frontend code
to the base of the repo
URL:
https://github.com/apache/incubator-superset/pull/9098#discussion_r376157853
##########
File path: superset-frontend/package.json
##########
@@ -13,7 +13,7 @@
"cover": "jest --coverage",
"dev": "webpack --mode=development --colors --progress --debug --watch",
"dev-server": "node --max_old_space_size=4096
./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=development
--progress",
- "prod": "node --max_old_space_size=4096 webpack --mode=production --colors
--progress",
+ "prod": "node --max_old_space_size=4096
./node_modules/webpack-dev-server/bin/webpack-dev-server.js --mode=production
--colors --progress",
Review comment:
do we want to be running the webpack-dev-server or just webpack for the prod
build?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
