etr2460 commented on a change in pull request #9138: [mypy] Enforcing typing
for db_engine_specs
URL:
https://github.com/apache/incubator-superset/pull/9138#discussion_r379242369
##########
File path: superset/db_engine_specs/base.py
##########
@@ -77,7 +83,7 @@ class TimeGrain(NamedTuple): # pylint:
disable=too-few-public-methods
class TimestampExpression(
ColumnClause
): # pylint: disable=abstract-method,too-many-ancestors,too-few-public-methods
- def __init__(self, expr: str, col: ColumnClause, **kwargs):
+ def __init__(self, expr: str, col: ColumnClause, **kwargs: Any) -> None:
Review comment:
can't kwargs be a `Dict[String, Any]`? Maybe we should define a global
`Kwargs` type that matches this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
