villebro commented on a change in pull request #9138: [mypy] Enforcing typing for db_engine_specs URL: https://github.com/apache/incubator-superset/pull/9138#discussion_r379495119
########## File path: superset/db_engine_specs/snowflake.py ########## @@ -47,14 +49,13 @@ class SnowflakeEngineSpec(PostgresBaseEngineSpec): } @classmethod - def adjust_database_uri(cls, uri, selected_schema=None): + def adjust_database_uri(cls, uri: URL, selected_schema: str = None) -> None: Review comment: Missing `Optional[]` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org