IndexOutOfRange opened a new pull request #9195: [WIP] Add Test SQL button to table explore view URL: https://github.com/apache/incubator-superset/pull/9195 ### CATEGORY Choose one - [X] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Fix issue https://github.com/apache/incubator-superset/issues/5417 This add a new button to check user SQL function in the table explore view when : - creating a new fields in a table - creating a new metrics in a table - I used the sql_json API to not create a new API - Used a popup as the test connection button. - Launch a query SELECT {expression} FROM {table} LIMIT 1 as suggested in the bug description ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF the button is present in the column tab and metric tab. this display a popup saying OK if it seems OK or display the SQL error :    ### TEST PLAN Manual test for the most of it (different column, tables, bases and with user with restricted access or not) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: Fix #5417 - [X] Changes UI : see screenshot - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
