villebro commented on issue #9195: [Explore] Add Test SQL button to table 
explore view
URL: 
https://github.com/apache/incubator-superset/pull/9195#issuecomment-594832401
 
 
   To address @willbarrett 's concern, instead of actually running the query, I 
wonder if it would be feasible to implement some type of sql statement dry run 
functionality in `BaseEngineSpec`. For instance, in Postgres one can prefix the 
query with `EXPLAIN`, which returns the following for a valid query:
   
![image](https://user-images.githubusercontent.com/33317356/75921684-38295a80-5e6a-11ea-9f1f-7ffa904cd241.png)
   When doing the same for an invalid query, it returns the following:
   
![image](https://user-images.githubusercontent.com/33317356/75921766-5f802780-5e6a-11ea-88bb-8a1cc7caca77.png)
   For other dbs without `EXPLAIN`, one could potentially do a `ROLLBACK` at 
the end or some other trickery.
   
   Personally, I don't particularly like the idea of running a query out of 
context like this, and can imagine some dbs potentially getting overloaded if 
the query generates a large number of rows.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to