[GitHub] [incubator-superset] suddjian opened a new pull request #9211: show edit modal on dashboards list view

[GitBox]

suddjian opened a new pull request #9211: show edit modal on dashboards list 
view
URL: https://github.com/apache/incubator-superset/pull/9211
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This changes the dashboard react list view to use the react-based edit 
modal, instead of linking to the CRUD-based edit page.
   
   A detail of this implementation is that after editing a dashboard, it will 
stay in the list even if it is no longer applicable based on the chosen 
filters. This is intended, as removing a dashboard that has been just edited 
from the list could be an annoying behavior.
   
   I had to remove the "owners" accessor column as it doesn't actually work 
correctly when a dashboard has `owners` populated. React complains about trying 
to render an object. Owners will need a component rather than just an accessor.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   After clicking the edit button
   <img width="1017" alt="Screen Shot 2020-02-26 at 11 51 47 AM" 
src="https://user-images.githubusercontent.com/1858430/75382042-a5e3ee00-588e-11ea-8861-40ebf88c0f90.png";>
   
   After saving the dashboard
   <img width="1025" alt="Screen Shot 2020-02-26 at 11 51 56 AM" 
src="https://user-images.githubusercontent.com/1858430/75382060-a8dede80-588e-11ea-8ea4-bc8dd819f8d5.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - Added a simple unit test
   - Smoke tested
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @nytai 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org