suddjian commented on a change in pull request #9211: show edit modal on
dashboards list view
URL:
https://github.com/apache/incubator-superset/pull/9211#discussion_r388477623
##########
File path: superset/views/dashboard/api.py
##########
@@ -142,19 +142,26 @@ class DashboardRestApi(DashboardMixin,
BaseOwnedModelRestApi):
class_permission_name = "DashboardModelView"
show_columns = [
+ "id",
"charts",
"css",
"dashboard_title",
"json_metadata",
"owners.id",
"owners.username",
+ "changed_by_name",
+ "changed_by_url",
+ "changed_by.username",
+ "changed_on",
"position_json",
"published",
+ "url",
"slug",
"table_names",
]
order_columns = ["dashboard_title", "changed_on", "published",
"changed_by_fk"]
list_columns = [
+ "json_metadata",
Review comment:
I ended up simplifying the contract for `PropertiesModal`, now it just takes
a dashboard id and fetches everything it needs on its own. Not ideal, it'd be
nicer to pass a dashboard object as a prop, but we don't have a super
consistent data model for a dashboard in every place that it's used, so it's
probably the best option for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
