graceguo-supercat opened a new pull request #9213: [fix] remove chart id from filter_scopes metadata if chart is not in dash anymore URL: https://github.com/apache/incubator-superset/pull/9213 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY when user or db migration removed a chart from dashboard, we didn't update filter_scopes metadata. It didn't cause any issue when we load filters in dashboard. But when user copy dashboard with slices, it will show error because dashboard can't find the new slice id from the copied dashboard: <img width="610" alt="Screen Shot 2020-02-26 at 12 18 08 PM" src="https://user-images.githubusercontent.com/27990562/75393360-bdc56d00-58a2-11ea-8662-270c11ff496b.png";> ### TEST PLAN CI and manual test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [X] Has associated issue: #9188 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @serenajiang @michellethomas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/75393360-bdc56d00-58a2-11ea-8662-270c11ff496b.png"](https://user-images.githubusercontent.com/27990562/75393360-bdc56d00-58a2-11ea-8662-270c11ff496b.png"){kind=link}