serenajiang commented on a change in pull request #9213: [fix] remove chart id
from filter_scopes metadata if chart is not in dash anymore
URL:
https://github.com/apache/incubator-superset/pull/9213#discussion_r384807104
##########
File path: superset/views/core.py
##########
@@ -1207,6 +1207,14 @@ def copy_dash(self, dashboard_id):
data["filter_scopes"] = json.dumps(new_filter_scopes)
else:
dash.slices = original_dash.slices
+ # remove slice id from filter_scopes metadata if slice is removed
from dashboard
+ if "filter_scopes" in data:
+ new_filter_scopes = copy_filter_scopes(
Review comment:
Not blocking, but is this still necessary even though the old slice and new
slice ids are the same?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
