ktmud opened a new pull request #9234: Perf: improve loading speed for legacy 
table chart
URL: https://github.com/apache/incubator-superset/pull/9234
 
 
   ### CATEGORY
   
   - [x] Enhancement (new features, refinement)
   
   ### SUMMARY
   
   One of the main pain points with the table chart is that it loads too slow 
for large datasets. This PR upgrades it to an updated version with improved 
performance. See [superset-ui-plugins 
PR#385](https://github.com/apache-superset/superset-ui-plugins/pull/385) for 
details.
   
   In addition to upgrade the table chart plugin, this PR also refactors some 
styling code related to it. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Tested with a ~10,000 rows, 7 columns table in Superset, pagination enabled:
   
   ### Before 
   
   
![legacy-table--old](https://user-images.githubusercontent.com/335541/75824956-4b98d080-5d59-11ea-9f86-4a17d0770e6c.gif)
   
   Takes about 6 secs to load.
   
   
![Snip20200303_3](https://user-images.githubusercontent.com/335541/75825254-d8dc2500-5d59-11ea-8da1-8091c8afcc8b.png)
   
   
   ### After
   
   
![legacy-table--new](https://user-images.githubusercontent.com/335541/75824966-4dfb2a80-5d59-11ea-83a4-0a3468f9f7c4.gif)
   
   Takes only 3 secs to load!
   
   
![Snip20200303_4](https://user-images.githubusercontent.com/335541/75825271-dda0d900-5d59-11ea-98a9-e04fc2445aac.png)
   
   
   ### TEST PLAN
   
   - Query a large dataset, increase row limit to a very high number
   - Feel the difference in reactiveness and loading speed of the table chart
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue:  this does not fix #8273 
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [x] Removes existing feature or API
   
   ### REVIEWERS
   
   @kristw @graceguo-supercat @etr2460 @rusackas 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to