ktmud commented on a change in pull request #9234: Perf: improve loading speed
for legacy table chart
URL:
https://github.com/apache/incubator-superset/pull/9234#discussion_r387355553
##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -222,13 +229,18 @@ class ChartRenderer extends React.Component {
queryResponse,
} = this.props;
+ let chartClassName = snakeCase(vizType);
+ if (isMigratedViz(vizType)) {
+ chartClassName = `superset-chart-${chartClassName}`;
+ }
+
return (
<>
{this.renderTooltip()}
<SuperChart
disableErrorBoundary
id={`chart-id-${chartId}`}
- className={`${snakeCase(vizType)}`}
+ className={chartClassName}
Review comment:
This will change (fix) the looks of the table chart.
Previously the whole table has a gray background:
which seems to be an unintentional because it comes from a CSS rule `.table
.table` for [nested Bootstrap
table](https://github.com/twbs/bootstrap/blob/68b0d231a13201eb14acd3dc84e51543d16e5f7e/less/tables.less#L84-L87).
Removing the background does also give us the strips:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
