oashton commented on issue #9210: Add maximize and minimize feature to charts URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-594720393 > > From what I understood, I needed to add a new conditional to force the update, that condition is the resize event, the `isFullSize` only represent the state not if new event (resize) was triggered. > > Okay, I think I understand. I think you could use `nextProps.isfullSize !== this.props.isFullSize`, then you wouldn't need `resizeEvent` anymore. Perfect, it worked.... I have commit the change b79ed4fc5348742c102b9e5313669749eb699700
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
