etr2460 commented on a change in pull request #9210: Add maximize and minimize
feature to charts
URL:
https://github.com/apache/incubator-superset/pull/9210#discussion_r387128023
##########
File path:
superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
##########
@@ -159,9 +171,14 @@ class ChartHolder extends React.Component {
});
}
+ handleFullSize() {
+ const flag = !this.state.isFullSize;
+ this.setState(() => ({ isFullSize: flag, resizeEvent: true }));
+ }
+
render() {
const { isFocused } = this.state;
-
+ const PADDING = 32;
Review comment:
prefer defining constants at the top of the file instead of in the render
function. Also, could use a more descriptive variable name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
