etr2460 commented on a change in pull request #9234: Perf: improve loading
speed for legacy table chart
URL:
https://github.com/apache/incubator-superset/pull/9234#discussion_r388025323
##########
File path: superset-frontend/src/chart/ChartRenderer.jsx
##########
@@ -222,13 +229,18 @@ class ChartRenderer extends React.Component {
queryResponse,
} = this.props;
+ let chartClassName = snakeCase(vizType);
+ if (isMigratedViz(vizType)) {
+ chartClassName = `superset-chart-${chartClassName}`;
+ }
+
return (
<>
{this.renderTooltip()}
<SuperChart
disableErrorBoundary
id={`chart-id-${chartId}`}
- className={`${snakeCase(vizType)}`}
+ className={chartClassName}
Review comment:
ooo, nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
