[GitHub] [incubator-superset] suddjian opened a new pull request #9267: [Charts] Use the Edit Properties modal throughout React views

Mon, 09 Mar 2020 13:44:57 -0700 

suddjian opened a new pull request #9267: [Charts] Use the Edit Properties 
modal throughout React views
URL: https://github.com/apache/incubator-superset/pull/9267
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The Edit Properties modal previously belonging only to the Explore dropdown 
is now used in the two additional places. This change replaces links to the 
CRUD edit page for charts.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   <img width="925" alt="Screen Shot 2020-03-09 at 1 43 57 PM" 
src="https://user-images.githubusercontent.com/1858430/76255842-1cc4a380-620c-11ea-8f1e-a1b96c4e65b4.png";>
   <img width="495" alt="Screen Shot 2020-03-09 at 1 44 15 PM" 
src="https://user-images.githubusercontent.com/1858430/76255844-1df5d080-620c-11ea-803c-dd50fa87193b.png";>
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @nytai

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to