rusackas commented on a change in pull request #9267: [Charts] Use the Edit
Properties modal throughout React views
URL:
https://github.com/apache/incubator-superset/pull/9267#discussion_r391295409
##########
File path: superset-frontend/src/explore/components/PropertiesModal.tsx
##########
@@ -44,9 +67,9 @@ function PropertiesModalWrapper({ show, onHide, animation,
slice, onSave }) {
);
}
-function PropertiesModal({ slice, onHide, onSave }) {
+function PropertiesModal({ slice, onHide, onSave }: InternalProps) {
const [submitting, setSubmitting] = useState(false);
- const errorDialog = useRef();
+ const errorDialog = useRef<any>(null);
Review comment:
I take it this could be anything, and we can't safely use
`<HTMLWhateverElement>` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
