codecov-io commented on issue #9211: show edit modal on dashboards list view URL: https://github.com/apache/incubator-superset/pull/9211#issuecomment-597826981 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=h1) Report > Merging [#9211](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/cd4605e4c1f1716dc182a6686991e971df924920&el=desc) will **increase** coverage by `0.21%`. > The diff coverage is `52.00%`. [](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #9211 +/- ## ========================================== + Coverage 58.92% 59.14% +0.21% ========================================== Files 372 373 +1 Lines 11999 12057 +58 Branches 2940 2961 +21 ========================================== + Hits 7071 7131 +60 + Misses 4750 4747 -3 - Partials 178 179 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `41.79% <ø> (ø)` | | | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `45.83% <50.00%> (+39.27%)` | :arrow_up: | | [...frontend/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2Rhc2hib2FyZExpc3QvRGFzaGJvYXJkTGlzdC50c3g=) | `63.63% <54.16%> (+4.28%)` | :arrow_up: | | [...erset-frontend/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC5qc3g=) | `75.70% <0.00%> (-1.86%)` | :arrow_down: | | [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `30.66% <0.00%> (-1.06%)` | :arrow_down: | | [...uperset-frontend/src/views/chartList/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NoYXJ0TGlzdC9DaGFydExpc3QudHN4) | `62.72% <0.00%> (-0.67%)` | :arrow_down: | | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.41% <0.00%> (ø)` | | | [superset-frontend/src/setup/setupClient.js](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ2xpZW50Lmpz) | `0.00% <0.00%> (ø)` | | | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `61.25% <0.00%> (ø)` | | | ... and [10 more](https://codecov.io/gh/apache/incubator-superset/pull/9211/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=footer). Last update [cd4605e...b3ff8fc](https://codecov.io/gh/apache/incubator-superset/pull/9211?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
