ktmud commented on a change in pull request #9284: Reduce dashboard bootstrap 
payload
URL: 
https://github.com/apache/incubator-superset/pull/9284#discussion_r391344642
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1788,25 +1788,40 @@ def dashboard(self, dashboard_id):
         dash = qry.one_or_none()
         if not dash:
             abort(404)
-        datasources = set()
+        datasources = {}
 
 Review comment:
   You can probably create a hash function in the datasource class?
   
   ```
   def ___hash__(self):
       return self.uid
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to