john-bodley commented on a change in pull request #9284: Reduce dashboard
bootstrap payload
URL:
https://github.com/apache/incubator-superset/pull/9284#discussion_r391871334
##########
File path: superset/views/core.py
##########
@@ -1807,6 +1809,11 @@ def dashboard(self, dashboard_id):
"superset/request_access/?" f"dashboard_id={dash.id}&"
)
+ # Filter out unneeded fields from the datasource payload
+ datasources_payload = {}
Review comment:
Could we make this a dictionary comprehension,
```python
datasources_payload = {
datasource.uid: datasource.data_for_slices(slices) for datasource,
slices in datasources.items()
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
